Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpStream Spacebeast #472

Merged
merged 25 commits into from
Jan 22, 2025
Merged

Conversation

The32bitguy
Copy link
Contributor

@The32bitguy The32bitguy commented Sep 25, 2024

About the pull request

soldier soldier-resting Soldier-Down Soldier-Dead

Builds off the following PR:
Credit to @FslashN from #233 for fixes to the code.
Credit to @AndroBetel from #161 for the initial sprites and code.

This PR is initially identical to #233 apart from the immedient fixes for it to run with #418 and #335

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Adds the Soldier, a new xeno caste for GMs to use. A high lethality, fast xenomorph with crowd control abilities and the motivation to attack human characters in a critical condition.
code: Swaps the order of sanity checks in the Headbite xeno ability
fix: Stops flares shot into the sky with the Unique-Action from being able to be melted or destroyed.
/:cl:

AndroBetel and others added 10 commits March 20, 2024 01:48
Adds all of the soldier AI behavior and abilities. Still a work in progress to an extent, but mostly feature complete. Also fixes a few runtimes.
Small fix to appease the linter gods.
Cleans up a few unnecessary lines that were left over from testing.
Small update to standing sprites, so that they actually display the correct directional. Behavior fix for hopefully better pathing.
@github-actions github-actions bot added Sprites Feature Missing Changelog Maintainers always document their changes. labels Sep 25, 2024
@The32bitguy The32bitguy marked this pull request as ready for review September 26, 2024 17:18
@The32bitguy The32bitguy marked this pull request as draft September 26, 2024 17:21
@The32bitguy The32bitguy changed the title [s] UpStream Spacebeast UpStream Spacebeast Oct 13, 2024
@Max-023
Copy link
Contributor

Max-023 commented Dec 25, 2024

so what exactly is this PR waiting on to get merged? genuinely curious

@The32bitguy
Copy link
Contributor Author

so what exactly is this PR waiting on to get merged? genuinely curious

I am apprehensive about merging this yet, because Soldiers are currently acting as a test bed for what might be the next iteration of "regular" xeno enemies. Also there are still weird interactions with their acid blood to some objects, like flares shot into the sky.

@The32bitguy The32bitguy marked this pull request as ready for review January 13, 2025 02:59
@mesnomer
Copy link
Contributor

One thing GMs have observed is that the headbite skill requires a workaround to trigger with movielike crit: we have to sleep people to do it at present.

Not sure the fix is to just let it headbite anyone in crit since that was particularly oppressive. Maybe in the later stages? Or even making it only an action a human player can take? In either case, I don't want to send you on a goose chase here, so definitely reach out if you'd like to get a conversation started about this and discuss options.

That's the only feedback I've seen from the GMs. Verbs is of the opinion it's fine as-is. Apologies for the lack of input so far -- I know that's frustrating.

@DexterDude DexterDude added the Stale Exempt YOU MUST CONSTRUCT ADDITIONAL MAINTAINERS label Jan 18, 2025
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added Code Improvement fix and removed Missing Changelog Maintainers always document their changes. labels Jan 20, 2025
@AndroBetel AndroBetel merged commit b444404 into cmss13-devs:master Jan 22, 2025
37 checks passed
cm13-github added a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Feature fix Sprites Stale Exempt YOU MUST CONSTRUCT ADDITIONAL MAINTAINERS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants